rasterstate/fj
rasterstate/fj
3
0
Fork 0
Code Issues 4 Pull requests Releases 5 Activity Actions

Consume fjord-core for stack absorb routing #189

Merged
stephen merged 1 commit from feat/consume-core-absorb into main 2026-06-19 17:06:47 +00:00
Conversation 0 Commits 1 Files changed 1 +13 -60
stephen commented 2026-06-19 16:54:23 +00:00
Owner
Copy link

Third slice of ADR-0001 Phase 3 (fj consumes the shared core), after review summarization (#187) and split planning (#188).

fj's absorb routing now delegates to fjord_core::workflows::stack:

  • index_commits, attribute_files, and plan_absorb call straight through.
  • FileAttribution, AbsorbGroup, and AbsorbPlan become re-exports of core's canonical records. The shapes are byte-identical (pub fields, same order, same serde layout), so this slice needs no conversion shim, unlike the split slice's i64→u64 PR-number narrowing.

Pure routing only, no behavior change: all absorb tests pass verbatim (index_commits sha→entry mapping, attribute_files routes/skips, plan_absorb grouping with empty-group drop, the render and JSON-shape assertions). 605 tests green, clippy -D warnings and fmt clean.

Third slice of ADR-0001 Phase 3 (fj consumes the shared core), after review summarization (#187) and split planning (#188). fj's absorb routing now delegates to `fjord_core::workflows::stack`: - `index_commits`, `attribute_files`, and `plan_absorb` call straight through. - `FileAttribution`, `AbsorbGroup`, and `AbsorbPlan` become re-exports of core's canonical records. The shapes are byte-identical (pub fields, same order, same serde layout), so this slice needs no conversion shim, unlike the split slice's i64→u64 PR-number narrowing. Pure routing only, no behavior change: all absorb tests pass verbatim (`index_commits` sha→entry mapping, `attribute_files` routes/skips, `plan_absorb` grouping with empty-group drop, the render and JSON-shape assertions). 605 tests green, clippy `-D warnings` and fmt clean.
Consume fjord-core for stack absorb routing
All checks were successful
ci / check (pull_request) Successful in 10m7s
Details
ci / coverage (pull_request) Successful in 1m41s
Details
ci / live-e2e (pull_request) Successful in 1m51s
Details
470f6db6f0
 
Promote fj's absorb routing (index_commits, attribute_files, plan_absorb)
into calls on fjord_core::workflows::stack, the third slice of ADR-0001
Phase 3 after split planning (#188). FileAttribution, AbsorbGroup, and
AbsorbPlan become re-exports of core's canonical records; the shapes are
byte-identical (pub fields, same order, same serde layout), so this slice
is pure delegation with no conversion shim. Behavior is unchanged: all
absorb tests pass verbatim.
stephen deleted branch feat/consume-core-absorb 2026-06-19 17:06:47 +00:00
stephen referenced this pull request from a commit 2026-06-19 17:09:08 +00:00
Consume fjord-core for stack naming
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog
Accepted but not scheduled

  
blocked
Blocked or stalled waiting on external progress

  
converted
Converted into tracked work

  
opportunity
Potential product or business opportunity

  
p1
Priority 1

  
p2
Priority 2

  
p3
Priority 3

  
parked
Paused intentionally until later

No labels
backlog
blocked
converted
opportunity
p1
p2
p3
parked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/fj!189
No description provided.