Consume fjord-core for stack review summarization #187

Merged

stephen merged 1 commit from feat/consume-fjord-core-reviews into main

2026-06-19 16:07:22 +00:00

stephen commented

2026-06-19 15:51:04 +00:00

Owner

First ADR-0001 Phase 3 slice: fj now depends on the shared fjord-core crate (resolved from the Forgejo cargo registry) and delegates stack review-state aggregation to fjord_core::workflows::stack::summarize_reviews.

The reduction (request-changes > approved > commented > none) and the ship-gate tokens it emits (changes_requested/approved/commented/none) now live in one place, so fj and the GUI clients can't drift on the verdict. Behavior is unchanged and fj's existing stack tests cover it.

Mechanics:

.cargo/config.toml registers the fjord registry (reads are open, so CI resolves without a token).
rust-version rises to 1.95 (CI already builds on 1.95) since core requires it; serde_json bumped to 1.0.150 for core's floor.
cargo-audit ignores two unmaintained-only advisories that arrive transitively through uniffi (bincode RUSTSEC-2025-0141, paste RUSTSEC-2024-0436), matching the existing proc-macro-error exception. No direct dependency on either.

This is the validate-first-by-fj step before the GUI surfaces adopt the same workflow.

First ADR-0001 Phase 3 slice: fj now depends on the shared `fjord-core` crate (resolved from the Forgejo cargo registry) and delegates stack review-state aggregation to `fjord_core::workflows::stack::summarize_reviews`. The reduction (request-changes > approved > commented > none) and the ship-gate tokens it emits (`changes_requested`/`approved`/`commented`/`none`) now live in one place, so fj and the GUI clients can't drift on the verdict. Behavior is unchanged and fj's existing stack tests cover it. Mechanics: - `.cargo/config.toml` registers the `fjord` registry (reads are open, so CI resolves without a token). - `rust-version` rises to 1.95 (CI already builds on 1.95) since core requires it; `serde_json` bumped to 1.0.150 for core's floor. - cargo-audit ignores two unmaintained-only advisories that arrive transitively through `uniffi` (bincode RUSTSEC-2025-0141, paste RUSTSEC-2024-0436), matching the existing proc-macro-error exception. No direct dependency on either. This is the validate-first-by-fj step before the GUI surfaces adopt the same workflow.

stephen added 1 commit

2026-06-19 15:51:04 +00:00

Consume fjord-core for stack review summarization

ci / check (pull_request) Successful in 12m55s

Details

ci / coverage (pull_request) Successful in 2m27s

Details

ci / live-e2e (pull_request) Successful in 2m52s

Details

4a0b60c428

First ADR-0001 Phase 3 slice: fj depends on the shared fjord-core crate from
the Forgejo cargo registry and delegates stack review-state aggregation to
fjord_core::workflows::stack::summarize_reviews. The reduction (request-changes
> approved > commented > none) and the ship-gate tokens it emits now live in one
place, so fj and the GUI clients can't drift on the verdict. Behavior is
unchanged; fj's existing stack tests cover it.

Raises fj's rust-version to 1.95 (CI already builds on 1.95) since core requires
it, and bumps serde_json to 1.0.150 to satisfy core's floor.

stephen merged commit c22b12361c into main

2026-06-19 16:07:22 +00:00

stephen deleted branch feat/consume-fjord-core-reviews

2026-06-19 16:07:22 +00:00

stephen referenced this pull request from a commit

2026-06-19 16:07:22 +00:00

Consume fjord-core for stack review summarization (#187)

stephen referenced this pull request from a commit

2026-06-19 16:37:07 +00:00

Consume fjord-core for stack split planning

stephen referenced this pull request

2026-06-19 16:37:18 +00:00