Consume fjord-core for stack naming #190

Merged

stephen merged 1 commit from feat/consume-core-naming into main

2026-06-19 17:21:43 +00:00

stephen commented

2026-06-19 17:09:14 +00:00

Owner

Fourth slice of ADR-0001 Phase 3 (fj consumes the shared core), after review summarization (#187), split planning (#188), and absorb routing (#189).

fj's stack naming now delegates to fjord_core::workflows::stack:

slugify, safe_handle, and item_branch call straight through.
These are the deterministic, branch-safe transforms that must match byte-for-byte across the CLI and mobile, so a stack authored on either surface lands on identical branch names. Centering them in core is exactly the drift the shared layer exists to prevent.

item_branch keeps fj's usize index ergonomics (its one in-crate call site passes a literal), casting to core's u32 internally. The unrelated slugify in issue.rs is a different transform (issue fallback, 40-char cap) and stays local.

No behavior change: all naming tests pass verbatim (slugify sanitize/fallback/cap, safe_handle precedence, item_branch determinism). 605 tests green, clippy -D warnings and fmt clean.

Fourth slice of ADR-0001 Phase 3 (fj consumes the shared core), after review summarization (#187), split planning (#188), and absorb routing (#189). fj's stack naming now delegates to `fjord_core::workflows::stack`: - `slugify`, `safe_handle`, and `item_branch` call straight through. - These are the deterministic, branch-safe transforms that must match byte-for-byte across the CLI and mobile, so a stack authored on either surface lands on identical branch names. Centering them in core is exactly the drift the shared layer exists to prevent. `item_branch` keeps fj's `usize` index ergonomics (its one in-crate call site passes a literal), casting to core's `u32` internally. The unrelated `slugify` in `issue.rs` is a different transform (`issue` fallback, 40-char cap) and stays local. No behavior change: all naming tests pass verbatim (slugify sanitize/fallback/cap, safe_handle precedence, item_branch determinism). 605 tests green, clippy `-D warnings` and fmt clean.

stephen added 1 commit

2026-06-19 17:09:15 +00:00

Consume fjord-core for stack naming

ci / check (pull_request) Successful in 10m1s

Details

ci / coverage (pull_request) Successful in 1m39s

Details

ci / live-e2e (pull_request) Successful in 1m53s

Details

5c9ba41ffe

Promote fj's stack naming (slugify, safe_handle, item_branch) into calls
on fjord_core::workflows::stack, the fourth slice of ADR-0001 Phase 3
after absorb routing (#189). These are the deterministic, branch-safe
string transforms that must match byte-for-byte across the CLI and mobile
so a stack authored on either lands on identical branch names; centering
them in core is the point of the shared layer.

item_branch keeps fj's usize index ergonomics (its one call site passes a
literal), casting to core's u32 internally. The unrelated slugify in
issue.rs is a different transform (issue fallback, 40-char cap) and stays
local. Behavior unchanged: all naming tests pass verbatim.

stephen merged commit 86f99d88df into main

2026-06-19 17:21:43 +00:00

stephen deleted branch feat/consume-core-naming

2026-06-19 17:21:43 +00:00

stephen referenced this pull request from a commit

2026-06-19 17:21:45 +00:00

Consume fjord-core for stack naming (#190)