rasterstate/fj
rasterstate/fj
3
0
Fork 0
Code Issues 4 Pull requests Releases 5 Activity Actions

Consume fjord-core for stack split planning #188

Merged
stephen merged 1 commit from feat/consume-core-split into main 2026-06-19 16:50:45 +00:00
Conversation 0 Commits 1 Files changed 2 +43 -51
stephen commented 2026-06-19 16:37:18 +00:00
Owner
Copy link

Second slice of ADR-0001 Phase 3 (fj consumes the shared core), after review summarization in #187.

fj's split planning now delegates to fjord_core::workflows::stack:

  • Commit becomes a re-export of core's canonical record (pub-field shape, identical layout).
  • parse_commits and validate_split call straight through; the validation error is mapped back to fj's bare message (core's Display prefixes invalid request:).
  • plan_split calls core and converts the planned items back to fj's StackItem via a new From impl, narrowing core's i64 PR number to fj's u64 (PR numbers are positive).

Pure planning only, no behavior change: all split tests pass verbatim (parse_commits, validate_split, plan_split chaining/fallback, the render and JSON-shape assertions). 605 tests green, clippy -D warnings and fmt clean.

Second slice of ADR-0001 Phase 3 (fj consumes the shared core), after review summarization in #187. fj's split planning now delegates to `fjord_core::workflows::stack`: - `Commit` becomes a re-export of core's canonical record (pub-field shape, identical layout). - `parse_commits` and `validate_split` call straight through; the validation error is mapped back to fj's bare message (core's `Display` prefixes `invalid request:`). - `plan_split` calls core and converts the planned items back to fj's `StackItem` via a new `From` impl, narrowing core's i64 PR number to fj's u64 (PR numbers are positive). Pure planning only, no behavior change: all split tests pass verbatim (`parse_commits`, `validate_split`, `plan_split` chaining/fallback, the render and JSON-shape assertions). 605 tests green, clippy `-D warnings` and fmt clean.
Consume fjord-core for stack split planning
All checks were successful
ci / check (pull_request) Successful in 10m50s
Details
ci / coverage (pull_request) Successful in 1m45s
Details
ci / live-e2e (pull_request) Successful in 2m3s
Details
d99dcd0edc
 
Promote fj's split planning (parse_commits, validate_split, plan_split)
into calls on fjord_core::workflows::stack, the second slice of ADR-0001
Phase 3 after review summarization (#187). The local Commit shape becomes
a re-export of core's canonical record, and core's planned items convert
back to fj's StackItem via a new From impl that narrows the i64 PR number
to fj's u64. Behavior is unchanged: all split tests pass verbatim.
stephen deleted branch feat/consume-core-split 2026-06-19 16:50:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog
Accepted but not scheduled

  
blocked
Blocked or stalled waiting on external progress

  
converted
Converted into tracked work

  
opportunity
Potential product or business opportunity

  
p1
Priority 1

  
p2
Priority 2

  
p3
Priority 3

  
parked
Paused intentionally until later

No labels
backlog
blocked
converted
opportunity
p1
p2
p3
parked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/fj!188
No description provided.