Wait out the double-tap window in tappingCountsUp #2

Merged
stephen merged 1 commit from fix-tap-test into main 2026-11-18 14:21:17 +00:00
Owner

One of five phone runs of the v1.0.0 pair failed tappingCountsUp on a Nokia 6.1 (API 29): the counter read "Taps: 1", expected "Taps: 2". The other four runs passed, so one of two back-to-back taps was lost. The test now checks after the first tap and waits one double-tap timeout plus 100 ms (bounded) before the second. Test change only; the app is unchanged. Needs a v1.0.1 tag build and a repeat run on phones before it counts as fixed.

One of five phone runs of the v1.0.0 pair failed tappingCountsUp on a Nokia 6.1 (API 29): the counter read "Taps: 1", expected "Taps: 2". The other four runs passed, so one of two back-to-back taps was lost. The test now checks after the first tap and waits one double-tap timeout plus 100 ms (bounded) before the second. Test change only; the app is unchanged. Needs a v1.0.1 tag build and a repeat run on phones before it counts as fixed.
The second of two back-to-back taps was lost on a Nokia 6.1 (API 29):
the counter read 1 instead of 2 in one of five runs. Check after the
first tap and wait one double-tap timeout before the second.
gerri approved these changes 2026-11-18 05:10:31 +00:00
gerri left a comment

Automated Codex review (read-only) of head 6a2fc2397c.

No actionable findings. The delay is bounded, and the test still checks that both taps increment the counter.

BLOCKING: 0

Reviewed head 6a2fc2397c at 2026-11-18T05:10:30Z by codex exec (read-only sandbox).

Automated Codex review (read-only) of head 6a2fc2397cc398dd78acf2ca9a412ca42d9812b9. No actionable findings. The delay is bounded, and the test still checks that both taps increment the counter. BLOCKING: 0 --- Reviewed head 6a2fc2397cc398dd78acf2ca9a412ca42d9812b9 at 2026-11-18T05:10:30Z by codex exec (read-only sandbox).
stephen deleted branch fix-tap-test 2026-11-18 14:21:17 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rasterstate/grid-sample-android!2
No description provided.