Make build identity, release name and artwork requirements host-configurable (GRD-488) #3
Loading…
Reference in a new issue
No description provided.
Delete branch "stephen/grd-488-host-agnostic"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
GRD-488. The code moved unchanged from fjord-ios, so a second app hit Fjord iOS's identity in three places. This makes them host-configurable.
ObservabilityConfigurationgains a requiredidentity: AppIdentity(store, development and optional lab bundle identifiers, Sentry release prefix).AnalyticsBuildChannel.classify,AnalyticsDefault.reportsByDefault,AnalyticsBuildAudienceandSentryBootstrap.releaseNameread it through default arguments, so explicit calls still work.AppIdentity.fjordIOSis the named constant fjord-ios passes. There is no default onidentity: an app that omits it fails to compile instead of being classified and released as Fjord iOS.AnalyticsBuildChannel.current,AnalyticsDefault.currentandAnalyticsBuildAudience.currentare computed on each read (they werestatic let) so a lateinstallis followed, not frozen.installfalls back to Fjord iOS's and logs one fault, in every build configuration (test runs exempt, since they install nothing).FjordLogoandSplashBackgroundlog a debug fault, once per name, when the host's asset catalog lacksFjordMonogramWhite,LaunchSplashorLaunchSplashPlain. README lists them as host requirements.RegularWidthReadableColumnappliessafeAreaPaddingunconditionally (zero below the threshold), so crossing the threshold on a window resize no longer swaps view branches and resets the content's state.install, the release name prefix, and the installed identity following changes.ObservabilityConfiguration(identity:)is required, so the fjord-ios bump passes.fjordIOSinObservabilityConfiguration.installForApp.Deliberate (self-review round 3): the review prefers latching the identity at first read after
install. Thecurrentvalues are recomputed instead because a latched early read would freeze a wrong classification for the whole process, and the fault now makes an early read visible.Known edge cases (follow-up):
AppBundle.base(Spotlight types, quick-action prefixes, notification names) is stillcom.rasterstate.fjordand is not part ofAppIdentity; the README says so. Fonts and strings remain GRD-486.Automated Codex review (read-only) of head
76598b8d14.No high or medium findings. The identity plumbing, the default-argument paths and the
RegularWidthReadableColumnchange are consistent across every changed caller I checked. The remaining items are low.Low
Sources/FjordObservability/ObservabilityConfiguration.swift:25,README.md(identity section). Invariant: a second app must not silently inherit Fjord iOS's identity.logSubsystemstill defaults to"com.rasterstate.fjord", andFatalCrashReportlogs under it (FatalCrashReport.swift:14). The README says to install "with the log subsystem", but its example omitslogSubsystem. A host that copies the example logs its crash reports under Fjord's subsystem with no signal, which is the failureidentitywas made required to prevent. Fix: makelogSubsystemrequired, or derive it fromidentity(for example the store bundle identifier). Otherwise add it to the README example and theAppBundle.basedeferral note.Low
Sources/FjordObservability/AnalyticsBuildChannel.swift:36,AnalyticsDefault.swift:23. Invariant: the early-read fault should fire only when the fallback identity can affect the answer.let identity = identity ?? ObservabilityConfiguration.identityruns before theisSimulatorandisDebugBuildshort-circuits. A host that reads.currentbeforeinstalltherefore logs the fault in every simulator and debug build, where the identity is irrelevant. That adds noise to the one signal this PR relies on. Fix: resolve the identity lazily, after those guards.Low
Tests/FjordObservabilityTests/FjordObservabilityTests.swift. Invariant: tests exercise the claim they name (STANDARDS item 13). Three claims in the PR body have no test:HostArtworkonce-per-name fault.RegularWidthReadableColumn.testAnInstalledIdentityIsWhatTheCurrentValuesUseand the sibling tests also callinstall(original)in theirdefer. That setsisInstalled = truefor the rest of the process. Fix: inject theisRunningTestscheck, or the logger, so the early-read path is testable. The other two can go in the body as untested, with a reason.Low
Sources/FjordObservability/AnalyticsBuildChannel.swift:54,AnalyticsEnvelopeFacts.swift:70. Invariant: a hot read should stay cheap.currentused to be a cachedstatic let. It now takes the config lock and callsBundle.main.appStoreReceiptURLon every read. If a host readsAnalyticsBuildAudience.currentper event, that is repeated work for a value that only changes atinstall. This is a performance concern only. Fix: cache by installed-configuration generation if profiling shows it matters.Low
.forgejo/workflows/ci.yml. The build and test steps now write xcodebuild output to a log and print only error lines plus the tail on failure. The title and body do not mention this change. The logic is sound:|| trueon thegreppipeline is safe underpipefail, and a non-zeroxcodebuildstill exits 1. Mention it in the PR body, since it affects how CI failures are read.Low (edge case, already deferred)
AppBundle.baseis still hard-coded to Fjord's identifier. It is listed in the PR body as a known edge case, so I'm not re-raising it.BLOCKING: 0
Reviewed head
76598b8d14at 2026-11-19T02:35:25Z by claude -p, read-only tools (Codex unavailable).