Import FjordIcons, FjordObservability and FjordDesignSystem from fjord-ios (GRD-476) #1
Loading…
Reference in a new issue
No description provided.
Delete branch "stephen/grd-476-import"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
GRD-476, step 2. Populates the empty repo with the three shared packages extracted in fjord-ios #2539 to #2542, as a single import commit naming the source commit (
rasterstate/fjord-iosdeb03c2346566e5708b1caa94134f91e3773ed79, main after #2542). History stays in fjord-ios.Package.swift, three library products:FjordIcons,FjordObservability,FjordDesignSystem(iOS 17, Swift 6). Sources are unchanged from fjord-ios.FjordDesignSystemdepends onFjordIcons;FjordObservabilitydepends onsentry-cocoaexact 9.34.0 (Sentry-Dynamic), the version fjord-ios pins..forgejo/workflows/ci.ymlonmacos-15-arm64with the fjord-ios conventions (Xcode 27.2, plain git checkout, a simulator created by id per job and deleted after): builds every product for the iOS Simulator, then runs the package tests.Known limits (follow-up, one issue: GRD-488, plus GRD-486): the code moved unchanged, so the Fjord iOS bundle identifiers and the
fjord-iosSentry release name are still hard-coded, the logo and splash artwork come from the host's asset catalog, andRegularWidthReadableColumnswaps view branches across its width threshold. Fonts and strings come from the host app (GRD-486). The README lists what a host provides.Automated Codex review (read-only) of head
fdbb9d9d68.The supplied diff ended partway through
fjord_direction_external_app_16.imageset/Contents.json. It omitted the remaining icon assets, allSources/FjordObservabilityfiles, both test files, andmanifest.json. I inspected the observability source and tests in the checkout; I did not visually inspect every omitted icon asset.BLOCKING: 0
Reviewed head
fdbb9d9d68at 2026-11-19T01:27:57Z by codex exec (read-only sandbox).Automated Codex review (read-only) of head
fdbb9d9d68.The supplied diff cuts off in
fjord_direction_external_app_16.imageset/Contents.json. It omits the rest of the icon asset catalog, allSources/FjordObservabilityfiles, both test files, andmanifest.json. The PNG contents are also absent from the unified diff. I inspected the observability source and tests in the checkout, but did not visually review every omitted image asset.I found no confirmed blocking problem. The PR’s stated GRD-488 and GRD-486 deferrals, including the readable-column branch swap, remain accepted follow-ups.
BLOCKING: 0
Reviewed head
fdbb9d9d68at 2026-11-19T01:28:45Z by codex exec (read-only sandbox).