Import FjordIcons, FjordObservability and FjordDesignSystem from fjord-ios (GRD-476) #1

Merged
stephen merged 1 commit from stephen/grd-476-import into main 2026-11-19 01:28:57 +00:00
Owner

GRD-476, step 2. Populates the empty repo with the three shared packages extracted in fjord-ios #2539 to #2542, as a single import commit naming the source commit (rasterstate/fjord-ios deb03c2346566e5708b1caa94134f91e3773ed79, main after #2542). History stays in fjord-ios.

  • Layout. One root Package.swift, three library products: FjordIcons, FjordObservability, FjordDesignSystem (iOS 17, Swift 6). Sources are unchanged from fjord-ios. FjordDesignSystem depends on FjordIcons; FjordObservability depends on sentry-cocoa exact 9.34.0 (Sentry-Dynamic), the version fjord-ios pins.
  • New in this commit. The root manifest, smoke tests for the observability and design system products (region consent, device identity, build channel, operated hosts, scrub, contrast, shell policy, refresh banner), the Forgejo CI workflow, the README (how a host consumes it and what it must provide).
  • CI. .forgejo/workflows/ci.yml on macos-15-arm64 with the fjord-ios conventions (Xcode 27.2, plain git checkout, a simulator created by id per job and deleted after): builds every product for the iOS Simulator, then runs the package tests.
  • Next. fjord-ios switches to this package at a tag Stephen pushes (a fjord-ios PR); the Grid app consumes the same tag.

Known limits (follow-up, one issue: GRD-488, plus GRD-486): the code moved unchanged, so the Fjord iOS bundle identifiers and the fjord-ios Sentry release name are still hard-coded, the logo and splash artwork come from the host's asset catalog, and RegularWidthReadableColumn swaps view branches across its width threshold. Fonts and strings come from the host app (GRD-486). The README lists what a host provides.

GRD-476, step 2. Populates the empty repo with the three shared packages extracted in fjord-ios #2539 to #2542, as a single import commit naming the source commit (`rasterstate/fjord-ios` `deb03c2346566e5708b1caa94134f91e3773ed79`, main after #2542). History stays in fjord-ios. - **Layout.** One root `Package.swift`, three library products: `FjordIcons`, `FjordObservability`, `FjordDesignSystem` (iOS 17, Swift 6). Sources are unchanged from fjord-ios. `FjordDesignSystem` depends on `FjordIcons`; `FjordObservability` depends on `sentry-cocoa` exact 9.34.0 (`Sentry-Dynamic`), the version fjord-ios pins. - **New in this commit.** The root manifest, smoke tests for the observability and design system products (region consent, device identity, build channel, operated hosts, scrub, contrast, shell policy, refresh banner), the Forgejo CI workflow, the README (how a host consumes it and what it must provide). - **CI.** `.forgejo/workflows/ci.yml` on `macos-15-arm64` with the fjord-ios conventions (Xcode 27.2, plain git checkout, a simulator created by id per job and deleted after): builds every product for the iOS Simulator, then runs the package tests. - **Next.** fjord-ios switches to this package at a tag Stephen pushes (a fjord-ios PR); the Grid app consumes the same tag. Known limits (follow-up, one issue: GRD-488, plus GRD-486): the code moved unchanged, so the Fjord iOS bundle identifiers and the `fjord-ios` Sentry release name are still hard-coded, the logo and splash artwork come from the host's asset catalog, and `RegularWidthReadableColumn` swaps view branches across its width threshold. Fonts and strings come from the host app (GRD-486). The README lists what a host provides.
Import FjordIcons, FjordObservability and FjordDesignSystem from fjord-ios
All checks were successful
CI / Build and test (iOS Simulator) (pull_request) Successful in 1m22s
fdbb9d9d68
Source: rasterstate/fjord-ios deb03c2346566e5708b1caa94134f91e3773ed79 (main
after #2542), Packages/FjordIcons, Packages/FjordObservability and
Packages/FjordDesignSystem. History stays in fjord-ios.

The three local packages become one root package with three library products
(iOS 17, Swift 6). Sources are unchanged. New: the root Package.swift, smoke
tests for the observability and design system products, the Forgejo CI workflow
for the macOS runners, and the README.
gerri approved these changes 2026-11-19 01:27:58 +00:00
Dismissed
gerri left a comment

Automated Codex review (read-only) of head fdbb9d9d68.

  • Low. RegularWidthReadableColumn.swift:26. Edge case. The invariant is that resizing preserves the content subtree’s state. Crossing the width threshold swaps branches and can reset list state. Keep the same view identity while changing the padding. This is the accepted GRD-488 follow-up described in the PR.

The supplied diff ended partway through fjord_direction_external_app_16.imageset/Contents.json. It omitted the remaining icon assets, all Sources/FjordObservability files, both test files, and manifest.json. I inspected the observability source and tests in the checkout; I did not visually inspect every omitted icon asset.

BLOCKING: 0

Reviewed head fdbb9d9d68 at 2026-11-19T01:27:57Z by codex exec (read-only sandbox).

Automated Codex review (read-only) of head fdbb9d9d685cc0e25d370fd714bde51cb4cb28ef. - **Low**. [RegularWidthReadableColumn.swift:26](/home/dev/work/reviews/rasterstate-fjord-apple-kit-1/Sources/FjordDesignSystem/RegularWidthReadableColumn.swift:26). **Edge case.** The invariant is that resizing preserves the content subtree’s state. Crossing the width threshold swaps branches and can reset list state. Keep the same view identity while changing the padding. This is the accepted GRD-488 follow-up described in the PR. The supplied diff ended partway through `fjord_direction_external_app_16.imageset/Contents.json`. It omitted the remaining icon assets, all `Sources/FjordObservability` files, both test files, and `manifest.json`. I inspected the observability source and tests in the checkout; I did not visually inspect every omitted icon asset. BLOCKING: 0 --- Reviewed head fdbb9d9d685cc0e25d370fd714bde51cb4cb28ef at 2026-11-19T01:27:57Z by codex exec (read-only sandbox).
gerri approved these changes 2026-11-19 01:28:46 +00:00
gerri left a comment

Automated Codex review (read-only) of head fdbb9d9d68.

The supplied diff cuts off in fjord_direction_external_app_16.imageset/Contents.json. It omits the rest of the icon asset catalog, all Sources/FjordObservability files, both test files, and manifest.json. The PNG contents are also absent from the unified diff. I inspected the observability source and tests in the checkout, but did not visually review every omitted image asset.

I found no confirmed blocking problem. The PR’s stated GRD-488 and GRD-486 deferrals, including the readable-column branch swap, remain accepted follow-ups.

BLOCKING: 0

Reviewed head fdbb9d9d68 at 2026-11-19T01:28:45Z by codex exec (read-only sandbox).

Automated Codex review (read-only) of head fdbb9d9d685cc0e25d370fd714bde51cb4cb28ef. The supplied diff cuts off in `fjord_direction_external_app_16.imageset/Contents.json`. It omits the rest of the icon asset catalog, all `Sources/FjordObservability` files, both test files, and `manifest.json`. The PNG contents are also absent from the unified diff. I inspected the observability source and tests in the checkout, but did not visually review every omitted image asset. I found no confirmed blocking problem. The PR’s stated GRD-488 and GRD-486 deferrals, including the readable-column branch swap, remain accepted follow-ups. BLOCKING: 0 --- Reviewed head fdbb9d9d685cc0e25d370fd714bde51cb4cb28ef at 2026-11-19T01:28:45Z by codex exec (read-only sandbox).
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rasterstate/fjord-apple-kit!1
No description provided.