Import the design system, observability and icon modules from fjord-android (GRD-498) #1

Merged
stephen merged 8 commits from import-from-fjord-android into main 2026-11-19 20:22:09 +00:00
Owner

GRD-498, step A5 (plan: grd-plans/grid-android-plan.md, issue A). The first import of the Android kit: the three modules fjord-android extracted locally in A0 to A4b, as one clean commit that names its source.

Source: rasterstate/fjord-android main at 87ba0f8cd: :designsystem (A2, #1475), :observability (A4 #1480, A4b #1481) and :fjordicons. The first commit imports them as they were at 0c2644f3c on the A4b branch; the merged main differs from it only by the classifier rename that #1481's CI required (the kit carries the same rename in its own commit), one PreviewSurface comment, and the module build files (:fjordicons is :icons here, plus a test dependency). Nothing else differs, checked file by file.

Layout

  • designsystem/, observability/: moved unchanged, packages included (com.rasterstate.fjord.ui.*, com.rasterstate.fjord.observability), so the app's imports did not move. Namespaces sh.fjord.kit.designsystem and sh.fjord.kit.observability; the package rename is a later release.
  • icons/ (sh.fjord.icons, :fjordicons renamed): generated, not copied by hand. Scripts/update-icons.sh takes the union of Config/icons-usage/*.json (today only fjord-android.json, the 149 keys fjord-android ships), runs package_usage.py from the pinned fjord-icons commit and syncs dist/fjord-android-kit/android. I ran it: the output equals fjord-android's fjordicons module byte for byte (298 icons, five densities); only the app slug in manifest.json differs. Grid's list lands in its own file when its app exists.
  • Scripts/check_icons_usage.py fails when a listed icon is missing, an unlisted icon is carried, or manifest.json, FjordIcons.java and the five drawable densities disagree. Its tests run in CI.
  • Build: Gradle 9.4.1 wrapper from the Forgejo package mirror, AGP 9.2.1, Kotlin 2.4.21, the version catalog trimmed to what the modules use, spotless (ktlint 1.8.0) and detekt with fjord-android's config. group = sh.fjord.kit on every module so a host can includeBuild this repo and depend on sh.fjord.kit:designsystem (composite build first, as decided; a registry later).
  • CI (.forgejo/workflows/ci.yml): the same heavy Linux pool, JDK 17 and Android SDK from the package registry, then spotlessCheck, detekt, assembleDebug assembleRelease testDebugUnitTest lintDebug; a second job runs the icon check on the light pool. No publish workflow yet: with a composite build there is nothing to publish.
  • Tests: the six designsystem tests that moved with their code, and the pure observability tests (FailureScrubberTest with a kit-local OperatedHostsRule, SentryEventScrubberTest, SentryDeviceRoleTest, SentryCrashSinkTest, BuildDistributionTest, AppOpenedTelemetryTest) plus ObservabilityConfigurationTest (release name, fail-closed default, the https-only guard, the scrubber keeping only operated-host paths). They still exist in fjord-android; A6 deletes them there.
  • README: what each module is, how a host consumes it, what a host provides (ObservabilityConfiguration, AnalyticsSettings, FailureFacts, the Sentry version), the icon flow and the build prerequisites.

Commits. (1) the import, unchanged from the source; (2) the four files over the 200-line limit split, and the scrubber test too (Theme 327 into Theme, ThemeColors, SystemBars; CrashSink 332 into the interface and no-op, SentryCrashSink and SentryPrivacyPolicy; ForgePaths 209 hands the web path rules to ForgeWebPaths; LayoutPolicyTest 286 and FailureScrubberTest 448 split by area; LocalStatusBarIconPins and SystemBarIcons became internal instead of private so Theme.kt can reach them; no behaviour change); (3) the source-size check adopted (the vendored checker at fjord-android's pin, its workflow, AGENTS.md, a config excluding only the generated icon sources and the Gradle wrapper script; no baseline, nothing is over the limit: the checker passes locally with 0 failures, 10 advisory warnings); (4) leftover imports.

Not in this PR

  • The Robolectric tests (SentryInstallIdTest, SentryCrashSinkOptionsTest, SentryCrashSinkRoleTest, LaunchTraceTest, SystemLocaleCountryTest, CrashReporterTest) stay in fjord-android for now: they need the Robolectric runtime staging fjord-android's CI has. Moving them, and the staging, is part of A6 or a small follow-up before it, so the code that decides what leaves the device is guarded in the kit.
  • The analytics engine (GRD-513) and the loaders, splash and list status views (they use app strings and drawables).
  • The source-size workflow cannot run on this PR (its base has no .source-size/ yet); the first PR after the merge proves it on the intended runner, as the adoption notes require. A tag: 0.1.0 is for the lead to push once main is green.

No Gradle on the host that wrote this, so nothing here has been built yet: the build, spotlessCheck, detekt, lintDebug and the unit tests are for this PR's first CI run, which is also the first time the kit builds on its own. Self-review read only part of the 1,581-file diff (the PNGs and generated Java are most of it) and found nothing blocking; its lows (a thin test set, two comments, the JDK download timeout) are addressed above.

Failure paths: n/a, an import with no new state.

Known edge cases (follow-up): the Robolectric tests and the source-size baseline, above.

GRD-498, step A5 (plan: `grd-plans/grid-android-plan.md`, issue A). The first import of the Android kit: the three modules fjord-android extracted locally in A0 to A4b, as one clean commit that names its source. **Source:** rasterstate/fjord-android `main` at `87ba0f8cd`: `:designsystem` (A2, #1475), `:observability` (A4 #1480, A4b #1481) and `:fjordicons`. The first commit imports them as they were at `0c2644f3c` on the A4b branch; the merged `main` differs from it only by the classifier rename that #1481's CI required (the kit carries the same rename in its own commit), one `PreviewSurface` comment, and the module build files (`:fjordicons` is `:icons` here, plus a test dependency). Nothing else differs, checked file by file. **Layout** - `designsystem/`, `observability/`: moved unchanged, packages included (`com.rasterstate.fjord.ui.*`, `com.rasterstate.fjord.observability`), so the app's imports did not move. Namespaces `sh.fjord.kit.designsystem` and `sh.fjord.kit.observability`; the package rename is a later release. - `icons/` (`sh.fjord.icons`, `:fjordicons` renamed): generated, not copied by hand. `Scripts/update-icons.sh` takes the union of `Config/icons-usage/*.json` (today only `fjord-android.json`, the 149 keys fjord-android ships), runs `package_usage.py` from the pinned `fjord-icons` commit and syncs `dist/fjord-android-kit/android`. I ran it: the output equals fjord-android's `fjordicons` module byte for byte (298 icons, five densities); only the app slug in `manifest.json` differs. Grid's list lands in its own file when its app exists. - `Scripts/check_icons_usage.py` fails when a listed icon is missing, an unlisted icon is carried, or `manifest.json`, `FjordIcons.java` and the five drawable densities disagree. Its tests run in CI. - Build: Gradle 9.4.1 wrapper from the Forgejo package mirror, AGP 9.2.1, Kotlin 2.4.21, the version catalog trimmed to what the modules use, spotless (ktlint 1.8.0) and detekt with fjord-android's config. `group = sh.fjord.kit` on every module so a host can `includeBuild` this repo and depend on `sh.fjord.kit:designsystem` (composite build first, as decided; a registry later). - CI (`.forgejo/workflows/ci.yml`): the same heavy Linux pool, JDK 17 and Android SDK from the package registry, then `spotlessCheck`, `detekt`, `assembleDebug assembleRelease testDebugUnitTest lintDebug`; a second job runs the icon check on the light pool. No publish workflow yet: with a composite build there is nothing to publish. - Tests: the six designsystem tests that moved with their code, and the pure observability tests (`FailureScrubberTest` with a kit-local `OperatedHostsRule`, `SentryEventScrubberTest`, `SentryDeviceRoleTest`, `SentryCrashSinkTest`, `BuildDistributionTest`, `AppOpenedTelemetryTest`) plus `ObservabilityConfigurationTest` (release name, fail-closed default, the https-only guard, the scrubber keeping only operated-host paths). They still exist in fjord-android; A6 deletes them there. - README: what each module is, how a host consumes it, what a host provides (`ObservabilityConfiguration`, `AnalyticsSettings`, `FailureFacts`, the Sentry version), the icon flow and the build prerequisites. **Commits.** (1) the import, unchanged from the source; (2) the four files over the 200-line limit split, and the scrubber test too (`Theme` 327 into `Theme`, `ThemeColors`, `SystemBars`; `CrashSink` 332 into the interface and no-op, `SentryCrashSink` and `SentryPrivacyPolicy`; `ForgePaths` 209 hands the web path rules to `ForgeWebPaths`; `LayoutPolicyTest` 286 and `FailureScrubberTest` 448 split by area; `LocalStatusBarIconPins` and `SystemBarIcons` became `internal` instead of `private` so `Theme.kt` can reach them; no behaviour change); (3) the source-size check adopted (the vendored checker at fjord-android's pin, its workflow, `AGENTS.md`, a config excluding only the generated icon sources and the Gradle wrapper script; no baseline, nothing is over the limit: the checker passes locally with 0 failures, 10 advisory warnings); (4) leftover imports. **Not in this PR** - The Robolectric tests (`SentryInstallIdTest`, `SentryCrashSinkOptionsTest`, `SentryCrashSinkRoleTest`, `LaunchTraceTest`, `SystemLocaleCountryTest`, `CrashReporterTest`) stay in fjord-android for now: they need the Robolectric runtime staging fjord-android's CI has. Moving them, and the staging, is part of A6 or a small follow-up before it, so the code that decides what leaves the device is guarded in the kit. - The analytics engine (GRD-513) and the loaders, splash and list status views (they use app strings and drawables). - The source-size workflow cannot run on this PR (its base has no `.source-size/` yet); the first PR after the merge proves it on the intended runner, as the adoption notes require. A tag: `0.1.0` is for the lead to push once main is green. No Gradle on the host that wrote this, so nothing here has been built yet: the build, `spotlessCheck`, `detekt`, `lintDebug` and the unit tests are for this PR's first CI run, which is also the first time the kit builds on its own. Self-review read only part of the 1,581-file diff (the PNGs and generated Java are most of it) and found nothing blocking; its lows (a thin test set, two comments, the JDK download timeout) are addressed above. Failure paths: n/a, an import with no new state. Known edge cases (follow-up): the Robolectric tests and the source-size baseline, above.
Import the design system, observability and icon modules from fjord-android (GRD-498)
Some checks failed
CI / icons (pull_request) Successful in 20s
CI / build (pull_request) Has been cancelled
60c309fe67
Source: rasterstate/fjord-android, the :designsystem, :observability and :fjordicons modules at 0c2644f3c (branch stephen/grd-498-a4b-split-crashreporter, PR #1481; the A4b commit that completes the observability split). The code is unchanged apart from the icon module's path (:fjordicons became :icons), a unit-test dependency in :observability and two comment fixes (PreviewSurface, the sdkDownload note).

Adds the build (wrapper, version catalog, spotless, detekt), the CI workflow, the icon union generator and its check, the README, the six designsystem tests that moved with their code and the pure observability tests (scrubbers, build distribution, Sentry sink helpers, app-opened telemetry) plus a configuration smoke test.
Theme.kt (327) is now Theme.kt, ThemeColors.kt and SystemBars.kt. CrashSink.kt (332) is the CrashSink interface and its no-op, SentryCrashSink.kt and SentryPrivacyPolicy.kt (the options the SDK is pinned to). ForgePaths.kt (209) hands the web path rules to ForgeWebPaths.kt. LayoutPolicyTest (286) and FailureScrubberTest (448) are split by area. No behaviour change; the only visibility changes are LocalStatusBarIconPins and SystemBarIcons, now internal instead of private so Theme.kt can reach them.
The vendored checker at the same pin as fjord-android, its workflow, AGENTS.md and a config that excludes only the generated icon sources and the Gradle wrapper script. No baseline: every handwritten file is under the 200-line limit, so the repository starts with the check on and nothing recorded as over.
Drop the imports the split left unused (GRD-498)
Some checks failed
CI / icons (pull_request) Successful in 10s
CI / build (pull_request) Has been cancelled
4217ac93ba
gerri approved these changes 2026-11-19 17:05:38 +00:00
Dismissed
gerri left a comment

Automated Codex review (read-only) of head 4217ac93ba.

I found nothing at high or medium severity.

I did not see the end of the diff. It was cut off inside icons/manifest.json, so the remaining manifest entries, the icon PNGs and the generated FjordIcons.java were not in front of me. The observability sources and tests and the observability Gradle file were also cut off, so I read the observability sources and observability/build.gradle.kts from the checkout. I did not build anything (no Gradle or SDK here), so build, spotlessCheck, detekt, lintDebug and the unit tests remain unproven until CI runs.

What I checked

  • Source-size pin: the SOURCE_SIZE_PIN in source-size.yml equals the sha256 of the vendored SHA256SUMS, and every listed tool file matches its hash.

  • Observability split: I diffed the first import against the head for CrashSink to SentryCrashSink and SentryPrivacyPolicy, and for ForgePaths to ForgeWebPaths. The moved code is verbatim, including the Sentry hardening options and the 2000 ms fatal flush. The REDACTED_* constants moved to file level, and ForgePaths now calls ForgeWebPaths.redact. Nothing else references the old redactWebPath or the old constant names.

  • Dependencies and wiring:

    • Observability imports resolve against its declared dependencies (core-ktx, Sentry, OkHttp, coroutines, serialization, compose runtime/ui).
    • settings.gradle.kts includes all three modules, and designsystem exposes :icons through api.
    • Group and namespace settings are consistent for the composite-build use described in the README.
  • Icon scripts: the union, check and update logic and its tests are consistent with each other. The CI icons job runs the tests and the check from the repo root.

  • Low (unchanged, by reference): the source size workflow cannot run on this PR because the base has no .source-size/. STANDARDS requires proving a new workflow on a real PR run, and the PR body defers that to the first PR after the merge. If source size is a required check on main, expect that first follow-up PR to be the real test. Also confirm policy/lint-workflow-bash.sh was run against source-size.yml.

  • Low (unchanged, by reference): the Robolectric tests, which guard what leaves the device, stay in fjord-android until A6. The PR body already lists this as a known edge case. Until they move, the kit's scrubber and Sentry sink are only guarded by the pure tests.

BLOCKING: 0


Reviewed head 4217ac93ba at 2026-11-19T17:05:37Z by claude -p, read-only tools (Codex unavailable).

Automated Codex review (read-only) of head 4217ac93ba6f82ad93906f201b492d64a4c04b76. I found nothing at high or medium severity. I did not see the end of the diff. It was cut off inside `icons/manifest.json`, so the remaining manifest entries, the icon PNGs and the generated `FjordIcons.java` were not in front of me. The observability sources and tests and the `observability` Gradle file were also cut off, so I read the observability sources and `observability/build.gradle.kts` from the checkout. I did not build anything (no Gradle or SDK here), so build, `spotlessCheck`, `detekt`, `lintDebug` and the unit tests remain unproven until CI runs. **What I checked** - **Source-size pin:** the `SOURCE_SIZE_PIN` in `source-size.yml` equals the sha256 of the vendored `SHA256SUMS`, and every listed tool file matches its hash. - **Observability split:** I diffed the first import against the head for `CrashSink` to `SentryCrashSink` and `SentryPrivacyPolicy`, and for `ForgePaths` to `ForgeWebPaths`. The moved code is verbatim, including the Sentry hardening options and the 2000 ms fatal flush. The `REDACTED_*` constants moved to file level, and `ForgePaths` now calls `ForgeWebPaths.redact`. Nothing else references the old `redactWebPath` or the old constant names. - **Dependencies and wiring:** - Observability imports resolve against its declared dependencies (core-ktx, Sentry, OkHttp, coroutines, serialization, compose runtime/ui). - `settings.gradle.kts` includes all three modules, and `designsystem` exposes `:icons` through `api`. - Group and namespace settings are consistent for the composite-build use described in the README. - **Icon scripts:** the union, check and update logic and its tests are consistent with each other. The CI `icons` job runs the tests and the check from the repo root. - **Low (unchanged, by reference):** the `source size` workflow cannot run on this PR because the base has no `.source-size/`. STANDARDS requires proving a new workflow on a real PR run, and the PR body defers that to the first PR after the merge. If `source size` is a required check on `main`, expect that first follow-up PR to be the real test. Also confirm `policy/lint-workflow-bash.sh` was run against `source-size.yml`. - **Low (unchanged, by reference):** the Robolectric tests, which guard what leaves the device, stay in fjord-android until A6. The PR body already lists this as a known edge case. Until they move, the kit's scrubber and Sentry sink are only guarded by the pure tests. BLOCKING: 0 --- Reviewed head 4217ac93ba6f82ad93906f201b492d64a4c04b76 at 2026-11-19T17:05:37Z by claude -p, read-only tools (Codex unavailable).
Rename the classifier's private extensions so they stop clashing with its public methods (GRD-498)
Some checks failed
CI / icons (pull_request) Successful in 7s
CI / build (pull_request) Failing after 5m3s
c0a50b88c3
Same fix as fjord-android#1481: the public methods and the private extensions they wrap shared JVM signatures.
gerri approved these changes 2026-11-19 17:51:32 +00:00
Dismissed
gerri left a comment

Automated Codex review (read-only) of head c0a50b88c3.

No high or medium findings. I read the diff but could not build anything, and the diff was truncated.

Not seen: the diff was cut at 400,000 of 1,078,303 bytes. I did not see the rest of the icons/manifest.json entries, the PNG drawables or the generated FjordIcons.java. The observability module, its tests and the designsystem fonts are outside the diff text I was given, so I read the main observability files from the checkout instead. I read ObservabilityConfiguration.kt and its test in full. For the rest I only grepped for Android API use. I did not open FailureScrubber, SentryCrashSink or the other privacy-relevant code. Nothing was built, so Gradle, detekt and lint are untested; the PR body already says so.

What I checked:

  • check_icons_usage.py and icons_union.py agree with each other and with their tests.

  • The unit tests in observability do not take an Android Context and use no Android framework calls beyond static fields, so they should run on the plain JVM without Robolectric.

  • ObservabilityConfigurationTest does exercise what its names claim: fail-closed default, https-only guard, operated-host path scrubbing.

  • Those tests change global state in ObservabilityConfiguration.current, but they restore it afterwards, and Gradle runs them one after another by default.

  • update-icons.sh uses rsync --delete on icons/. That is safe only because the generated output includes icons/build.gradle.kts, which the PR says it does.

  • Low .forgejo/workflows/source-size.yml:1 (STANDARDS "Source file size"): the standard requires proving the workflow on the repo's own runner before merge. This PR cannot do that, because pull_request_target runs the workflow from main, which has no .source-size/ yet. The PR body discloses this and defers to the first PR after merge. The risk is that a bug in the workflow or the pin only shows up after merge and then fails every later PR, and that a required "source size" check never reports on this PR. Fix: ask the lead to approve the bootstrap explicitly, and have a trivial follow-up PR ready to prove it right after merge.

  • Low (edge case) .forgejo/scripts/install-android-sdk.sh:51-76: the script is not safe to re-run. If a runner keeps $HOME/android-sdk between jobs, unzip hits existing files and prompts, and the mv ... latest step nests the directory. This only matters on a non-ephemeral runner, and the script is copied from fjord-android. Fix: add unzip -oq, and rm -rf "$SDK/cmdline-tools/latest" before the mv.

  • Low designsystem/build.gradle.kts:41 and observability/build.gradle.kts:34: the Compose, material3 and okhttp dependencies are implementation, but public types expose them (ColorScheme in DesignTheme, okhttp3.Interceptor in HttpsOnlyGuard). A host that includeBuilds the kit and does not declare those libraries itself will not compile against them. fjord-android has them, so this is harmless today. Grid may not, so switch those to api when Grid adopts the kit.

BLOCKING: 0


Reviewed head c0a50b88c3 at 2026-11-19T17:51:31Z by claude -p, read-only tools (Codex unavailable).

Automated Codex review (read-only) of head c0a50b88c332bb40c02b08da21714c8ed27d6b4d. No high or medium findings. I read the diff but could not build anything, and the diff was truncated. **Not seen:** the diff was cut at 400,000 of 1,078,303 bytes. I did not see the rest of the `icons/manifest.json` entries, the PNG drawables or the generated `FjordIcons.java`. The `observability` module, its tests and the `designsystem` fonts are outside the diff text I was given, so I read the main `observability` files from the checkout instead. I read `ObservabilityConfiguration.kt` and its test in full. For the rest I only grepped for Android API use. I did not open `FailureScrubber`, `SentryCrashSink` or the other privacy-relevant code. Nothing was built, so Gradle, detekt and lint are untested; the PR body already says so. **What I checked:** - `check_icons_usage.py` and `icons_union.py` agree with each other and with their tests. - The unit tests in `observability` do not take an Android `Context` and use no Android framework calls beyond static fields, so they should run on the plain JVM without Robolectric. - `ObservabilityConfigurationTest` does exercise what its names claim: fail-closed default, https-only guard, operated-host path scrubbing. - Those tests change global state in `ObservabilityConfiguration.current`, but they restore it afterwards, and Gradle runs them one after another by default. - `update-icons.sh` uses `rsync --delete` on `icons/`. That is safe only because the generated output includes `icons/build.gradle.kts`, which the PR says it does. - **Low** `.forgejo/workflows/source-size.yml:1` (STANDARDS "Source file size"): the standard requires proving the workflow on the repo's own runner before merge. This PR cannot do that, because `pull_request_target` runs the workflow from `main`, which has no `.source-size/` yet. The PR body discloses this and defers to the first PR after merge. The risk is that a bug in the workflow or the pin only shows up after merge and then fails every later PR, and that a required "source size" check never reports on this PR. Fix: ask the lead to approve the bootstrap explicitly, and have a trivial follow-up PR ready to prove it right after merge. - **Low** (edge case) `.forgejo/scripts/install-android-sdk.sh:51-76`: the script is not safe to re-run. If a runner keeps `$HOME/android-sdk` between jobs, `unzip` hits existing files and prompts, and the `mv ... latest` step nests the directory. This only matters on a non-ephemeral runner, and the script is copied from fjord-android. Fix: add `unzip -oq`, and `rm -rf "$SDK/cmdline-tools/latest"` before the `mv`. - **Low** `designsystem/build.gradle.kts:41` and `observability/build.gradle.kts:34`: the Compose, material3 and okhttp dependencies are `implementation`, but public types expose them (`ColorScheme` in `DesignTheme`, `okhttp3.Interceptor` in `HttpsOnlyGuard`). A host that includeBuilds the kit and does not declare those libraries itself will not compile against them. fjord-android has them, so this is harmless today. Grid may not, so switch those to `api` when Grid adopts the kit. BLOCKING: 0 --- Reviewed head c0a50b88c332bb40c02b08da21714c8ed27d6b4d at 2026-11-19T17:51:31Z by claude -p, read-only tools (Codex unavailable).
The policy was lifted out of SentryAndroid.init's lambda, whose parameter is SentryAndroidOptions; as a plain SentryOptions it could not see the Android-only settings (screenshot, view hierarchy, ANR, NDK).
Keep Sentry from auto-initializing in any host (GRD-498)
Some checks failed
CI / icons (pull_request) Successful in 8s
CI / build (pull_request) Failing after 9m52s
4556ca5949
The never-initialized-cannot-send guarantee in SentryCrashSink.enable depended on each host's manifest. The library now carries io.sentry.auto-init=false, as fjord-android's own manifest does.
gerri requested changes 2026-11-19 18:28:43 +00:00
Dismissed
gerri left a comment

Automated Codex review (read-only) of head 4556ca5949.

Review is done, with one blocking finding. I read the diff up to the truncation point (partway through icons/manifest.json). I didn't see the rest of that manifest or the drawables and FjordIcons.java, so those are unreviewed. I read the observability sources from the checkout instead. I couldn't run Python, Gradle or ktlint here, so everything below comes from reading the code.

  • High designsystem/src/test/java/com/rasterstate/fjord/ui/layout/LayoutPolicyShellTest.kt:3

    • Invariant: the first CI run must pass spotlessCheck, and CI runs it first. The ktlint no-unused-imports rule is part of ktlint_official.
    • What is wrong: splitting LayoutPolicyTest left import androidx.compose.ui.unit.dp in the Shell test, and nothing in that file uses it. The only dp hits are in comments and strings ("a dp too narrow"). The DpSize and .dp usage moved to LayoutTestWindows.kt. Commit 4 ("Drop the imports the split left unused") missed this one.
    • Failure scenario: ./gradlew spotlessCheck fails on this file, so the build job stops at the first gate and detekt, assemble, tests and lint never run. The PR says nothing has been built yet, so this red is visible on the first run.
    • Fix: delete line 3. I didn't check the other split files (Theme, SystemBars, ThemeColors, CrashSink, ForgePaths, the FailureScrubber*Test files, LayoutPolicyWorkItemTest, LayoutPolicyWorkstationTest) for the same leftover. Run nice -n 19 ~/fleet-week/ktlint.sh <worktree> origin/main on the changed files and commit whatever it reports.
  • Low designsystem/src/main/java/com/rasterstate/fjord/ui/layout/LayoutPolicy.kt:16 and LayoutPolicyShellTest.kt:108

    • Invariant: docs should name what exists.
    • What is wrong: the KDoc points at [LayoutPolicyTest], which the split removed. The test comment points at ReviewWorkstationRestorationTest, which isn't in this kit.
    • Failure scenario: a dangling KDoc link. This changes nothing at runtime.
    • Fix: point both at the real test classes.
  • Low .forgejo/workflows/source-size.yml

    • Invariant: STANDARDS says adopting source-size means proving the workflow on the repo's own runner before merge.
    • What is wrong: the body says it cannot run on this PR, because the base has no .source-size/. That is unavoidable for a bootstrap PR. The proof is deferred to the first PR after merge and is already listed in the PR body.
    • Fix: none now; just keep the follow-up. Also run policy/lint-workflow-bash.sh on the workflow, since the body doesn't mention it.

Everything else I checked looks fine for normal operation. The observability code is a straight move. The Sentry privacy policy is intact. The manifest sets io.sentry.auto-init=false and a host's own value wins. The tests I read use only io.sentry types and pure JVM logic, so they shouldn't need Robolectric.

BLOCKING: 1


Reviewed head 4556ca5949 at 2026-11-19T18:28:42Z by claude -p, read-only tools (Codex unavailable).

Automated Codex review (read-only) of head 4556ca59496a700df8874ea6cd9423e74a561b3a. Review is done, with one blocking finding. I read the diff up to the truncation point (partway through `icons/manifest.json`). I didn't see the rest of that manifest or the drawables and `FjordIcons.java`, so those are unreviewed. I read the observability sources from the checkout instead. I couldn't run Python, Gradle or ktlint here, so everything below comes from reading the code. - **High** `designsystem/src/test/java/com/rasterstate/fjord/ui/layout/LayoutPolicyShellTest.kt:3` - **Invariant:** the first CI run must pass `spotlessCheck`, and CI runs it first. The ktlint `no-unused-imports` rule is part of `ktlint_official`. - **What is wrong:** splitting `LayoutPolicyTest` left `import androidx.compose.ui.unit.dp` in the Shell test, and nothing in that file uses it. The only `dp` hits are in comments and strings ("a dp too narrow"). The `DpSize` and `.dp` usage moved to `LayoutTestWindows.kt`. Commit 4 ("Drop the imports the split left unused") missed this one. - **Failure scenario:** `./gradlew spotlessCheck` fails on this file, so the `build` job stops at the first gate and detekt, assemble, tests and lint never run. The PR says nothing has been built yet, so this red is visible on the first run. - **Fix:** delete line 3. I didn't check the other split files (Theme, SystemBars, ThemeColors, CrashSink, ForgePaths, the `FailureScrubber*Test` files, `LayoutPolicyWorkItemTest`, `LayoutPolicyWorkstationTest`) for the same leftover. Run `nice -n 19 ~/fleet-week/ktlint.sh <worktree> origin/main` on the changed files and commit whatever it reports. - **Low** `designsystem/src/main/java/com/rasterstate/fjord/ui/layout/LayoutPolicy.kt:16` and `LayoutPolicyShellTest.kt:108` - **Invariant:** docs should name what exists. - **What is wrong:** the KDoc points at `[LayoutPolicyTest]`, which the split removed. The test comment points at `ReviewWorkstationRestorationTest`, which isn't in this kit. - **Failure scenario:** a dangling KDoc link. This changes nothing at runtime. - **Fix:** point both at the real test classes. - **Low** `.forgejo/workflows/source-size.yml` - **Invariant:** STANDARDS says adopting source-size means proving the workflow on the repo's own runner before merge. - **What is wrong:** the body says it cannot run on this PR, because the base has no `.source-size/`. That is unavoidable for a bootstrap PR. The proof is deferred to the first PR after merge and is already listed in the PR body. - **Fix:** none now; just keep the follow-up. Also run `policy/lint-workflow-bash.sh` on the workflow, since the body doesn't mention it. Everything else I checked looks fine for normal operation. The observability code is a straight move. The Sentry privacy policy is intact. The manifest sets `io.sentry.auto-init=false` and a host's own value wins. The tests I read use only `io.sentry` types and pure JVM logic, so they shouldn't need Robolectric. BLOCKING: 1 --- Reviewed head 4556ca59496a700df8874ea6cd9423e74a561b3a at 2026-11-19T18:28:42Z by claude -p, read-only tools (Codex unavailable).
Restore the delegate imports SystemBars needs (GRD-498)
All checks were successful
CI / icons (pull_request) Successful in 20s
CI / build (pull_request) Successful in 5m3s
1e8049b27f
The unused-import cleanup after the Theme split removed getValue and setValue, which the mutableIntStateOf property delegate in StatusBarIconPins needs.
gerri approved these changes 2026-11-19 19:24:12 +00:00
gerri left a comment

Automated Codex review (read-only) of head 1e8049b27f.

I could only partly review this PR. The diff was cut at icons/manifest.json, so I did not see the icon PNGs, FjordIcons.java, the observability and designsystem tests past what the diff showed, or any observability/ Kotlin sources. I read those sources and .source-size/tool/SHA256SUMS in the checkout instead. Nothing was built or run. The listed observability sources are all at most 199 lines, and the pin in source-size.yml matches the SHA256SUMS hash. I found nothing that will plausibly break in normal operation.

  • Low, .forgejo/workflows/source-size.yml (whole file). Invariant: STANDARDS "Source file size" says a workflow adopted in a repo must be proven by a real PR run on that repo's runner before merge, and policy/lint-workflow-bash.sh must be run on it. The PR body says the workflow cannot run here because the base has no .source-size/, and it does not mention the lint. actions/checkout@v6 also differs from the @v4 that ci.yml uses, and I could not check that the runner mirror carries it. Scenario: if the workflow has a defect (a missing shasum, an unavailable action version), the first PR after merge fails the source size check, and a required check would block every PR until someone fixes it. Fix: run policy/lint-workflow-bash.sh now and record the result in the PR body. Prove the workflow with a throwaway PR into a branch that already carries .source-size/ before relying on it.

  • Low, observability/src/main/AndroidManifest.xml:5, and the "Nothing else differs, checked file by file" claim in the PR body. Invariant: behaviour changes are stated. Commit 4556ca5 adds io.sentry.auto-init=false to the library manifest, and the commit list does not mention it as a change from the source. The README does document it. Scenario: a host that gets Sentry only through manifest auto-init stops reporting without any code change. SentryCrashSink.enable does call SentryAndroid.init explicitly, so a host that goes through the sink is unaffected. Fix: list the manifest addition in the PR body as a deliberate change.

  • Low, .forgejo/scripts/install-android-sdk.sh:50-77. Invariant: CI setup steps are idempotent on a persistent self-hosted runner. unzip -q into $SDK, followed by mv into latest, 36.0.0 and the platform directory, is not safe to re-run when those paths already exist. unzip asks about overwriting and fails with no stdin, and mv can nest the directory inside itself. The archive cache under ~/.cache suggests $HOME persists. It is copied from fjord-android, so it may already work there with fresh containers. Fix: remove $SDK before unpacking, or use unzip -oq and rm -rf the target before each mv.

  • Low, observability/build.gradle.kts:40. Invariant: public API types are visible to consumers. okhttp is an implementation dependency, but HttpsOnlyGuard is a public okhttp3.Interceptor, and FailureClassifier uses okhttp3.internal.http2.StreamResetException, which is internal API. Scenario: a host on a different OkHttp version or a Gradle strict-API setup breaks, and an OkHttp bump can break the classifier without warning. Fix: expose okhttp as api, or document that the host must match the pinned version.

BLOCKING: 0


Reviewed head 1e8049b27f at 2026-11-19T19:24:11Z by claude -p, read-only tools (Codex unavailable).

Automated Codex review (read-only) of head 1e8049b27f846c4b87141087e725aec01c38ad21. I could only partly review this PR. The diff was cut at `icons/manifest.json`, so I did not see the icon PNGs, `FjordIcons.java`, the observability and designsystem tests past what the diff showed, or any `observability/` Kotlin sources. I read those sources and `.source-size/tool/SHA256SUMS` in the checkout instead. Nothing was built or run. The listed observability sources are all at most 199 lines, and the pin in `source-size.yml` matches the `SHA256SUMS` hash. I found nothing that will plausibly break in normal operation. - **Low**, `.forgejo/workflows/source-size.yml` (whole file). Invariant: STANDARDS "Source file size" says a workflow adopted in a repo must be proven by a real PR run on that repo's runner before merge, and `policy/lint-workflow-bash.sh` must be run on it. The PR body says the workflow cannot run here because the base has no `.source-size/`, and it does not mention the lint. `actions/checkout@v6` also differs from the `@v4` that `ci.yml` uses, and I could not check that the runner mirror carries it. Scenario: if the workflow has a defect (a missing `shasum`, an unavailable action version), the first PR after merge fails the source size check, and a required check would block every PR until someone fixes it. Fix: run `policy/lint-workflow-bash.sh` now and record the result in the PR body. Prove the workflow with a throwaway PR into a branch that already carries `.source-size/` before relying on it. - **Low**, `observability/src/main/AndroidManifest.xml:5`, and the "Nothing else differs, checked file by file" claim in the PR body. Invariant: behaviour changes are stated. Commit `4556ca5` adds `io.sentry.auto-init=false` to the library manifest, and the commit list does not mention it as a change from the source. The README does document it. Scenario: a host that gets Sentry only through manifest auto-init stops reporting without any code change. `SentryCrashSink.enable` does call `SentryAndroid.init` explicitly, so a host that goes through the sink is unaffected. Fix: list the manifest addition in the PR body as a deliberate change. - **Low**, `.forgejo/scripts/install-android-sdk.sh:50-77`. Invariant: CI setup steps are idempotent on a persistent self-hosted runner. `unzip -q` into `$SDK`, followed by `mv` into `latest`, `36.0.0` and the platform directory, is not safe to re-run when those paths already exist. `unzip` asks about overwriting and fails with no stdin, and `mv` can nest the directory inside itself. The archive cache under `~/.cache` suggests `$HOME` persists. It is copied from fjord-android, so it may already work there with fresh containers. Fix: remove `$SDK` before unpacking, or use `unzip -oq` and `rm -rf` the target before each `mv`. - **Low**, `observability/build.gradle.kts:40`. Invariant: public API types are visible to consumers. `okhttp` is an `implementation` dependency, but `HttpsOnlyGuard` is a public `okhttp3.Interceptor`, and `FailureClassifier` uses `okhttp3.internal.http2.StreamResetException`, which is internal API. Scenario: a host on a different OkHttp version or a Gradle strict-API setup breaks, and an OkHttp bump can break the classifier without warning. Fix: expose okhttp as `api`, or document that the host must match the pinned version. BLOCKING: 0 --- Reviewed head 1e8049b27f846c4b87141087e725aec01c38ad21 at 2026-11-19T19:24:11Z by claude -p, read-only tools (Codex unavailable).
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rasterstate/fjord-android-kit!1
No description provided.