Waive RUSTSEC-2026-0543 (chrono) until 2027-02-17 (PLAT-906) #331

Merged
stephen merged 1 commit from stephen/waive-rustsec-2026-0543 into main 2026-11-17 22:31:39 +00:00
Owner

cargo audit -D warnings fails on RUSTSEC-2026-0543: chrono 0.4.44 is unmaintained and there is no fixed release. fj uses chrono directly, so it cannot be dropped yet. This waives it with a dated reason, tracked in PLAT-906, expiring 2027-02-17.

  • The waivers move to .cargo/audit.toml (the four existing ones plus this one), so CI, hooks/pre-push, make audit and the docs share one list instead of repeating --ignore flags.
  • scripts/audit.sh runs cargo audit -D warnings and fails once the chrono waiver is past its date. The check only applies while the waiver is in the file, so removing the line removes the check.
  • CI, the pre-push hook, Makefile, CONTRIBUTING, CLAUDE.md and the PR template call scripts/audit.sh. A bare cargo audit still honours the ignore but skips the date check; CI is the gate.

Known limit (self-review, Low): the expiry check greps for the quoted advisory id, so a commented-out entry or single quotes in the TOML would fool it. Not worth a TOML parser in a shell script for a one-entry list.

Checked locally: the script's expiry path (fails with AUDIT_TODAY=2027-03-01), the removed-waiver path, and bash -n on the script and hook. The real cargo audit run is CI's.

#330 (Peter Swimm's patches) is untouched; it picks this up by updating with main after this merges.

`cargo audit -D warnings` fails on RUSTSEC-2026-0543: chrono 0.4.44 is unmaintained and there is no fixed release. fj uses chrono directly, so it cannot be dropped yet. This waives it with a dated reason, tracked in PLAT-906, expiring 2027-02-17. - The waivers move to `.cargo/audit.toml` (the four existing ones plus this one), so CI, `hooks/pre-push`, `make audit` and the docs share one list instead of repeating `--ignore` flags. - `scripts/audit.sh` runs `cargo audit -D warnings` and fails once the chrono waiver is past its date. The check only applies while the waiver is in the file, so removing the line removes the check. - CI, the pre-push hook, Makefile, CONTRIBUTING, CLAUDE.md and the PR template call `scripts/audit.sh`. A bare `cargo audit` still honours the ignore but skips the date check; CI is the gate. Known limit (self-review, Low): the expiry check greps for the quoted advisory id, so a commented-out entry or single quotes in the TOML would fool it. Not worth a TOML parser in a shell script for a one-entry list. Checked locally: the script's expiry path (fails with `AUDIT_TODAY=2027-03-01`), the removed-waiver path, and `bash -n` on the script and hook. The real `cargo audit` run is CI's. #330 (Peter Swimm's patches) is untouched; it picks this up by updating with main after this merges.
Waive RUSTSEC-2026-0543 (chrono unmaintained) until 2027-02-17 (PLAT-906)
All checks were successful
ci / check (pull_request) Successful in 22m54s
ci / live-e2e (pull_request) Successful in 5m30s
ci / coverage (pull_request) Successful in 6m25s
6e11911b10
The waivers move to .cargo/audit.toml so CI, the pre-push hook, make audit and
scripts/audit.sh share one list. scripts/audit.sh fails once the dated waiver
has expired.
gerri approved these changes 2026-11-17 22:01:58 +00:00
gerri left a comment

Automated Codex review (read-only) of head 6e11911b10.

  • Low scripts/audit.sh:8: Invariant: the expiry check applies exactly while the chrono waiver is active. As noted in the PR’s known limit, commenting out the double-quoted entry still triggers expiry, while changing it to valid single-quoted TOML bypasses expiry. This affects every script-based entry point. Fix by reading the parsed TOML advisory list. This is an edge case already acknowledged in the PR.

BLOCKING: 0

Reviewed head 6e11911b10 at 2026-11-17T22:01:57Z by codex exec (read-only sandbox).

Automated Codex review (read-only) of head 6e11911b1073d1c65ab0292cb0dfa7a198f58904. - **Low** [scripts/audit.sh:8](/home/dev/work/reviews/rasterstate-fj-331/scripts/audit.sh:8): **Invariant:** the expiry check applies exactly while the chrono waiver is active. As noted in the PR’s known limit, commenting out the double-quoted entry still triggers expiry, while changing it to valid single-quoted TOML bypasses expiry. This affects every script-based entry point. Fix by reading the parsed TOML advisory list. This is an edge case already acknowledged in the PR. BLOCKING: 0 --- Reviewed head 6e11911b1073d1c65ab0292cb0dfa7a198f58904 at 2026-11-17T22:01:57Z by codex exec (read-only sandbox).
Sign in to join this conversation.
No description provided.