Filter the inbox with the connected account's mute list (CLS-1264) #325
Loading…
Reference in a new issue
No description provided.
Delete branch "cls-1264-inbox-scope"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CLS-1264, broad half, part 2 of 2 (part 1 was #324).
fj statusconnected a client, then calledaccount_scope(host), which loadshosts.tomlagain to work out the mute scope. A switch from another terminal between the two could filter one account's notifications with another account's mute list.muted::client_scope(&client)builds the scope from the host configuration the client connected with (client.config(), added in #324).fj statususes it.account_scopestays forstatus mute,unmuteandmuted, which never connect and read once. Its doc comment now says so.Tests:
the_inbox_scope_follows_the_connected_client_not_the_diskconnects, switches the account on disk, and checks the client's scope is still the original account's whileaccount_scopenow names the other one (so it fails if the reload comes back).the_inbox_scope_follows_the_connected_fjord_instance: each Fjord instance has its own scope.tests/status_mute_scope.rsend to end:status muteunder one account, thenstatushides that repo for that account only, which also showsclient_scopeequals the scopemutestored.Self-review (two rounds, BLOCKING 0) left one Low: a test that switches
hosts.tomlbetweenconnectand the scope lookup insideinboxitself. That window has no network call and no seam, so a subprocess test cannot interleave there, and I did not add a test-only hook to production code. The call site is one line (client_scope(&client)).Automated Codex review (read-only) of head
4ac3d246dd.No new correctness, security, or failure-path problems found against STANDARDS.md. The PR body's deferred Low test gap remains unchanged: switching configuration inside
inboxis not directly exercised.Review was read-only; tests were not run.
BLOCKING: 0
Reviewed head
4ac3d246ddat 2026-11-12T10:54:33Z by codex exec (read-only sandbox).