Record that fj never sends the imported cookie (CLS-1267) #319

Merged
stephen merged 1 commit from stephen/cls-1267-close-cookie into main 2026-11-12 01:39:33 +00:00
Owner

Closes CLS-1267 item 1 as won't-do. Stephen decided fj never sends the imported browser cookie: it stays stored and listed only, because a browser session is broader authority than a token.

web_client said a Fjord Account gateway "does not forward web routes". That stopped being true (the gateway forwards web paths; see #313). The comment and the user-facing refusal now say fj attaches no credential to a web fallback and the gateway cannot authenticate one. profile_session::cookie gets a note that no request path may send the cookie.

No request behaviour changes.

Closes CLS-1267 item 1 as won't-do. Stephen decided fj never sends the imported browser cookie: it stays stored and listed only, because a browser session is broader authority than a token. `web_client` said a Fjord Account gateway "does not forward web routes". That stopped being true (the gateway forwards web paths; see #313). The comment and the user-facing refusal now say fj attaches no credential to a web fallback and the gateway cannot authenticate one. `profile_session::cookie` gets a note that no request path may send the cookie. No request behaviour changes.
Record that fj never sends the imported cookie and fix the gateway comment (CLS-1267)
All checks were successful
ci / check (pull_request) Successful in 26m2s
ci / live-e2e (pull_request) Successful in 5m33s
ci / coverage (pull_request) Successful in 6m58s
de278608ec
Stephen decided the imported browser cookie is stored and listed only.
web_client's comment and error said the gateway does not forward web routes,
which stopped being true; reword both.
gerri approved these changes 2026-11-12 01:08:02 +00:00
gerri left a comment

Automated Codex review (read-only) of head de278608ec.

No actionable findings. The diff changes comments and refusal wording only; the inspected request paths do not send imported cookies.

BLOCKING: 0

Reviewed head de278608ec at 2026-11-12T01:08:02Z by codex exec (read-only sandbox).

Automated Codex review (read-only) of head de278608eca587b4d567b13b4e1b2ea4850c4c5f. No actionable findings. The diff changes comments and refusal wording only; the inspected request paths do not send imported cookies. BLOCKING: 0 --- Reviewed head de278608eca587b4d567b13b4e1b2ea4850c4c5f at 2026-11-12T01:08:02Z by codex exec (read-only sandbox).
Sign in to join this conversation.
No description provided.