Test interrupted artifact downloads without publishing files (CLS-1203) #304
Loading…
Reference in a new issue
No description provided.
Delete branch "stephen/cls-1203-download-length-check"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CLS-1203. #298 already makes
fjcompare the body with Content-Length, retry short or broken bodies, and install atomically, and it tests a short Content-Length body. What was not covered is a connection reset in the middle of the body.This adds a Unix-only regression test: the server sends headers and a partial body, then closes abortively (SO_LINGER 0, so the client sees a reset). It goes through
api::workflow::download_artifactanddownload::write_atomic, and checks that:No production code changes.
Failure paths: 2 (retries exhaust and fail, nothing is recorded as done), 4 (a transport error is an error, not a short success), 13 (the test uses a real socket reset, not a mock). Other checklist items: n/a, test only.
Tests:
cargo test --bin fj reset_mid_stream_exhausts_retries_without_publishing_artifactandartifact_content_length_mismatch_retries_then_fails_without_filepass locally.Automated Codex review (read-only) of head
ec75e721df.No actionable findings against the diff or STANDARDS.md. Tests were not run in the read-only sandbox.
BLOCKING: 0
Reviewed head
ec75e721dfat 2026-11-08T03:32:23Z by codex exec (read-only sandbox).