Consume fjord-core for stack PR-body annotation #192

Merged
stephen merged 1 commit from feat/stack-delegate-annotation into main 2026-06-19 18:22:57 +00:00
Owner

Delegates fj's PR-description stack navigation to fjord_core 0.1.2, completing the ADR-0001 Phase 3 stack extraction. The block markup, embedded payload, escaping, and splice rules now live in the core engine (with its own tests); fj passes only its caption label (fj stack sync) through the command argument.

  • annotate_prs builds core's Stack once and calls apply_stack_navigation per item; the local block/payload helpers (render_stack_block, apply_stack_block, stack_payload, payload_comment, and their consts/structs) are removed.
  • Drops the duplicated render/apply/payload unit tests in favor of core's; keeps a fj-level guard that the supplied caption flows into the rendered block.

Behavior is unchanged.

Delegates fj's PR-description stack navigation to `fjord_core` 0.1.2, completing the ADR-0001 Phase 3 stack extraction. The block markup, embedded payload, escaping, and splice rules now live in the core engine (with its own tests); fj passes only its caption label (`fj stack sync`) through the command argument. - `annotate_prs` builds core's `Stack` once and calls `apply_stack_navigation` per item; the local block/payload helpers (`render_stack_block`, `apply_stack_block`, `stack_payload`, `payload_comment`, and their consts/structs) are removed. - Drops the duplicated render/apply/payload unit tests in favor of core's; keeps a fj-level guard that the supplied caption flows into the rendered block. Behavior is unchanged.
Consume fjord-core for stack PR-body annotation
All checks were successful
ci / check (pull_request) Successful in 10m13s
ci / coverage (pull_request) Successful in 1m44s
ci / live-e2e (pull_request) Successful in 1m59s
ea89567988
Delegates fj's PR-description stack navigation to fjord_core 0.1.2. The
block markup, embedded payload, escaping, and splice rules now live in the
core engine (with its own tests); fj passes only its caption label
(`fj stack sync`) through the new command argument.

- annotate_prs builds core's Stack once and calls apply_stack_navigation
  per item; the local block/payload helpers and their structs are removed.
- Drops the duplicated render/apply/payload tests in favor of core's; keeps
  a fj-level guard that the supplied caption flows into the rendered block.

Behavior is unchanged.
stephen deleted branch feat/stack-delegate-annotation 2026-06-19 18:22:58 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/fj!192
No description provided.