rasterstate/fj
rasterstate/fj
3
0
Fork 0
Code Issues 4 Pull requests Releases 5 Activity Actions

Add -F/--body-file to issue/pr comment verbs #186

Merged
stephen merged 2 commits from feat/body-file-comments into main 2026-06-17 18:46:03 +00:00
Conversation 0 Commits 2 Files changed 3 +204 -43
stephen commented 2026-06-17 18:08:51 +00:00
Owner
Copy link

Adds -F/--body-file (mutually exclusive with --body, - reads stdin) to the comment add and edit verbs of fj issue comment and fj pr comment, closing the gh-parity gap where only the top-level issue/pr/release/milestone commands accepted a body file. Factors the stdin/editor body resolution into a comment_body helper that reuses the existing editor::resolve_body_input, and covers the body-file, stdin-marker, and --body/--body-file conflict paths with arg-parse tests. Closes #124.

Adds `-F/--body-file` (mutually exclusive with `--body`, `-` reads stdin) to the comment add and edit verbs of `fj issue comment` and `fj pr comment`, closing the gh-parity gap where only the top-level issue/pr/release/milestone commands accepted a body file. Factors the stdin/editor body resolution into a `comment_body` helper that reuses the existing `editor::resolve_body_input`, and covers the body-file, stdin-marker, and `--body`/`--body-file` conflict paths with arg-parse tests. Closes #124.
Add --body-file for issue and PR comment editing
Some checks failed
ci / check (pull_request) Failing after 1m0s
Details
ci / coverage (pull_request) Has been skipped
Details
ci / live-e2e (pull_request) Has been skipped
Details
29bbecf540
Drop issue_comment from COV_IGNORE now that it has unit tests
All checks were successful
ci / check (pull_request) Successful in 10m10s
Details
ci / coverage (pull_request) Successful in 2m2s
Details
ci / live-e2e (pull_request) Successful in 1m53s
Details
b557723cbf
 
The body-file tests added a #[cfg(test)] module to cli/issue_comment.rs,
which the cov_ignore_stays_in_sync structural guard requires be removed
from COV_IGNORE. Drop it from the regex and the prose list, and mark the
three async handlers coverage(off) so the strict-coverage floor still
reflects only the tested helpers, matching cli/pr_comment.rs.
stephen deleted branch feat/body-file-comments 2026-06-17 18:46:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog
Accepted but not scheduled

  
blocked
Blocked or stalled waiting on external progress

  
converted
Converted into tracked work

  
opportunity
Potential product or business opportunity

  
p1
Priority 1

  
p2
Priority 2

  
p3
Priority 3

  
parked
Paused intentionally until later

No labels
backlog
blocked
converted
opportunity
p1
p2
p3
parked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/fj!186
No description provided.