rasterstate/fj
rasterstate/fj
3
0
Fork 0
Code Issues 4 Pull requests Releases 5 Activity Actions

Route delete_comment through ensure_success for friendly not-found #184

Merged
stephen merged 1 commit from fix/delete-comment-ensure-success into main 2026-06-17 18:25:33 +00:00
Conversation 0 Commits 1 Files changed 3 +21 -3
stephen commented 2026-06-17 18:07:56 +00:00
Owner
Copy link

Routes delete_comment through ensure_success instead of the bare res.error_for_status()?, so deleting a missing comment now yields a friendly not found: message and exits EXIT_NOT_FOUND (3) rather than EXIT_GENERIC (1), matching edit_comment. Promotes ensure_success to pub(crate) and adds a wiremock test asserting a 404 delete surfaces a not-found error. Closes #150.

Routes `delete_comment` through `ensure_success` instead of the bare `res.error_for_status()?`, so deleting a missing comment now yields a friendly `not found:` message and exits `EXIT_NOT_FOUND` (3) rather than `EXIT_GENERIC` (1), matching `edit_comment`. Promotes `ensure_success` to `pub(crate)` and adds a wiremock test asserting a 404 delete surfaces a not-found error. Closes #150.
Map issue comment delete errors through ensure_success
All checks were successful
ci / check (pull_request) Successful in 9m45s
Details
ci / live-e2e (pull_request) Successful in 1m44s
Details
ci / coverage (pull_request) Successful in 2m1s
Details
beab057ea9
stephen deleted branch fix/delete-comment-ensure-success 2026-06-17 18:25:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog
Accepted but not scheduled

  
blocked
Blocked or stalled waiting on external progress

  
converted
Converted into tracked work

  
opportunity
Potential product or business opportunity

  
p1
Priority 1

  
p2
Priority 2

  
p3
Priority 3

  
parked
Paused intentionally until later

No labels
backlog
blocked
converted
opportunity
p1
p2
p3
parked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/fj!184
No description provided.