rasterstate/download-artifact-action
2
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

Clarify sidecar fail-closed: replace dead sidecar-less fallback with a clear error #12

Merged
stephen merged 1 commit from fix/10-sidecar-failclosed into main 2026-06-24 19:21:11 +00:00
Conversation 0 Commits 1 Files changed 4 +13 -10
stephen commented 2026-06-24 18:35:38 +00:00
Owner
Copy link

Closes #10.

Why: the sidecar-less fallback in loadMeta returned a meta object with no digest, which then threw deep in verifyDigest — so the path was dead code presented as supported, and a missing sidecar failed with a confusing error.

  • Missing .meta.json sidecar now fails closed with a clear, intentional message (refusing to download an unverified archive), instead of the fallback's misleading throw.
  • README + CHANGELOG updated to state the sidecar is required (fail-closed). No new skip-verification path; behavior for valid sidecar-present artifacts is unchanged.
  • Test covers the missing-sidecar case.

Testing: tests/download.test.js + repo CI.

DO NOT MERGE: lead/operator review.

Closes #10. Why: the sidecar-less fallback in loadMeta returned a meta object with no digest, which then threw deep in verifyDigest — so the path was dead code presented as supported, and a missing sidecar failed with a confusing error. - Missing .meta.json sidecar now fails closed with a clear, intentional message (refusing to download an unverified archive), instead of the fallback's misleading throw. - README + CHANGELOG updated to state the sidecar is required (fail-closed). No new skip-verification path; behavior for valid sidecar-present artifacts is unchanged. - Test covers the missing-sidecar case. Testing: tests/download.test.js + repo CI. DO NOT MERGE: lead/operator review.
Clarify sidecar fail-closed downloads
All checks were successful
test / unit (pull_request) Successful in 23s
Details
test / e2e (pull_request) Successful in 4s
Details
68e17403b2
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog
Accepted but not scheduled

  
blocked
Blocked or stalled waiting on external progress

  
converted
Converted into tracked work

  
opportunity
Potential product or business opportunity

  
p1
Priority 1

  
p2
Priority 2

  
p3
Priority 3

  
parked
Paused intentionally until later

No labels
backlog
blocked
converted
opportunity
p1
p2
p3
parked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/download-artifact-action!12
No description provided.