rasterstate/create-pull-request-action
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[security] Stop embedding token in push URL (use http.extraheader) #7

Merged
stephen merged 1 commit from fix/6-token-url-leak into main 2026-06-23 22:11:28 +00:00
Conversation 0 Commits 1 Files changed 2 +36 -16
stephen commented 2026-06-23 20:47:21 +00:00
Owner
Copy link

Closes #6.

Why: the token was embedded in the push remote URL. setSecret masks the raw token but git stderr echoes the URL-encoded credential, which can leak into logs on a push failure.

  • Credential moved out of the URL into http.extraheader (Authorization: Basic) via GIT_CONFIG_* env, applied to push/fetch/ls-remote.
  • Defense-in-depth: setSecret the encodeURIComponent(token) form too.

Testing: tests/run.sh + new assertion that the remote URL carries no credential.

DO NOT MERGE: security-sensitive; lead/operator review.

Closes #6. Why: the token was embedded in the push remote URL. setSecret masks the raw token but git stderr echoes the URL-encoded credential, which can leak into logs on a push failure. - Credential moved out of the URL into `http.extraheader` (Authorization: Basic) via GIT_CONFIG_* env, applied to push/fetch/ls-remote. - Defense-in-depth: setSecret the encodeURIComponent(token) form too. Testing: tests/run.sh + new assertion that the remote URL carries no credential. DO NOT MERGE: security-sensitive; lead/operator review.
Avoid token-bearing git remote URLs
All checks were successful
test / unit (pull_request) Successful in 11s
Details
e40dc2e935
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog
Accepted but not scheduled

  
blocked
Blocked or stalled waiting on external progress

  
converted
Converted into tracked work

  
opportunity
Potential product or business opportunity

  
p1
Priority 1

  
p2
Priority 2

  
p3
Priority 3

  
parked
Paused intentionally until later

No labels
backlog
blocked
converted
opportunity
p1
p2
p3
parked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/create-pull-request-action!7
No description provided.