CONTRIBUTING: DCO sign-off and how to run the tests #334

Merged
stephen merged 1 commit from stephen/contributing-dco-tests into main 2026-11-18 21:35:54 +00:00
Owner

CLS-1325 follow-up: outside contributors now have a written rule and a how-to.

  • DCO sign-off: every commit carries Signed-off-by: (git commit -s), with the one-line certification and the command that fixes a branch (git rebase --force-rebase --signoff main; plain --signoff skips commits it does not need to move). CI does not enforce it yet; maintainers will ask.
  • Tests: replaces the stale "60 tests" line with what to run before a PR (fmt, clippy with -D warnings, cargo test --all --locked, on the 1.95 toolchain from rust-version) and what CI adds.
  • Subprocess tests: set FJ_CONFIG_DIR (and FJ_NO_KEYCHAIN=1) on the command, as in tests/support/account_override.rs, because macOS ignores XDG_CONFIG_HOME and the binary would read the developer's real config. This is the fix from Peter Swimm's patch in #330.

Docs only. The license line (MIT, contributions under the same license) is unchanged.

CLS-1325 follow-up: outside contributors now have a written rule and a how-to. * DCO sign-off: every commit carries `Signed-off-by:` (`git commit -s`), with the one-line certification and the command that fixes a branch (`git rebase --force-rebase --signoff main`; plain `--signoff` skips commits it does not need to move). CI does not enforce it yet; maintainers will ask. * Tests: replaces the stale "60 tests" line with what to run before a PR (fmt, clippy with `-D warnings`, `cargo test --all --locked`, on the 1.95 toolchain from `rust-version`) and what CI adds. * Subprocess tests: set `FJ_CONFIG_DIR` (and `FJ_NO_KEYCHAIN=1`) on the command, as in `tests/support/account_override.rs`, because macOS ignores `XDG_CONFIG_HOME` and the binary would read the developer's real config. This is the fix from Peter Swimm's patch in #330. Docs only. The license line (MIT, contributions under the same license) is unchanged.
CONTRIBUTING: DCO sign-off, how to run the tests, FJ_CONFIG_DIR for subprocess tests
All checks were successful
ci / check (pull_request) Successful in 26m0s
ci / live-e2e (pull_request) Successful in 3m53s
ci / coverage (pull_request) Successful in 5m18s
8f1914b6f0
gerri approved these changes 2026-11-18 21:01:33 +00:00
gerri left a comment

Automated Codex review (read-only) of head 8f1914b6f0.

No actionable findings.

BLOCKING: 0

Reviewed head 8f1914b6f0 at 2026-11-18T21:01:31Z by codex exec (read-only sandbox).

Automated Codex review (read-only) of head 8f1914b6f0c348002e74e0b8b746f4afababda8b. No actionable findings. BLOCKING: 0 --- Reviewed head 8f1914b6f0c348002e74e0b8b746f4afababda8b at 2026-11-18T21:01:31Z by codex exec (read-only sandbox).
Sign in to join this conversation.
No description provided.