Correct Actions cancel API fallback wording #277

New issue

Open

opened 2026-10-05 00:29:42 +00:00 by stephen · 0 comments

stephen commented

2026-10-05 00:29:42 +00:00

Owner

The current fj run cancel fallback says Forgejo has no rerun/cancel API when a token-authenticated web action returns 404. Forgejo now has POST /repos/{owner}/{repo}/actions/runs/{run_id}/cancel on servers that advertise run-cancel capability; Fjord iOS and Android gate their calls on that capability. The CLI still uses a web action and run URL fallback.

Update the CLI comment and fallback text so they describe the unavailable token-authenticated web action without claiming the REST cancel endpoint does not exist. Decide separately whether fj run cancel should call the capability-gated REST endpoint. The shared contract update is tracked in rasterstate/fjord-client-spec#45.

Evidence: src/api/workflow_run.rs at ea895679888fe0d23c974961796a6f78a00be553, Fjord iOS Fjord/Features/Actions/CancelActionRun.swift at f5162ece359d4a88ee445009ea1c79c532a264f1, and Fjord Android ActionRunDetailViewModel.kt at c8415dc89ff05999d9b3d007a308fdb3603f0ca6.

The current `fj run cancel` fallback says Forgejo has no rerun/cancel API when a token-authenticated web action returns 404. Forgejo now has `POST /repos/{owner}/{repo}/actions/runs/{run_id}/cancel` on servers that advertise run-cancel capability; Fjord iOS and Android gate their calls on that capability. The CLI still uses a web action and run URL fallback. Update the CLI comment and fallback text so they describe the unavailable token-authenticated web action without claiming the REST cancel endpoint does not exist. Decide separately whether `fj run cancel` should call the capability-gated REST endpoint. The shared contract update is tracked in rasterstate/fjord-client-spec#45. Evidence: `src/api/workflow_run.rs` at `ea895679888fe0d23c974961796a6f78a00be553`, Fjord iOS `Fjord/Features/Actions/CancelActionRun.swift` at `f5162ece359d4a88ee445009ea1c79c532a264f1`, and Fjord Android `ActionRunDetailViewModel.kt` at `c8415dc89ff05999d9b3d007a308fdb3603f0ca6`.